From b24e4aa47b22a4d0494f7a11076fbfac89ec4997 Mon Sep 17 00:00:00 2001
From: Matt Ralston <mralston@myune.edu.au>
Date: Tue, 4 Jul 2023 14:40:33 +1000
Subject: [PATCH] Fixed two known bugs
---
src/main/java/dotsandboxes/DotsAndBoxesGrid.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/main/java/dotsandboxes/DotsAndBoxesGrid.java b/src/main/java/dotsandboxes/DotsAndBoxesGrid.java
index a9e7c5b..27113c9 100644
--- a/src/main/java/dotsandboxes/DotsAndBoxesGrid.java
+++ b/src/main/java/dotsandboxes/DotsAndBoxesGrid.java
@@ -111,8 +111,7 @@ public class DotsAndBoxesGrid {
}
// A box is complete if the north and south horizontals and the east and west verticals have all been drawn.
- // FIXME: You'll need to fix this code (after writing a test first).
- return true;
+ return horizontals[x][y] && horizontals[x][y+1] && verticals[x][y] && verticals[x+1][y];
}
/** Tries to claim a box for a player. If the box is complete, sets the ownership and returns true. */
@@ -139,7 +138,9 @@ public class DotsAndBoxesGrid {
throw new IndexOutOfBoundsException(String.format("y was %d, which is out of range. Range is 0 to %d", y, height));
}
- // FIXME: You need to throw an exception if the line was already drawn.
+ if (this.horizontals[x][y]) {
+ throw new IllegalStateException(String.format("line at %d, %d was already drawn and cannot be redrawn.", x, y));
+ }
this.horizontals[x][y] = true;
--
GitLab