Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
A
Assessment2
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Brett McAndrew
Assessment2
Compare revisions
9e7607fa2e13259b15385726baf74bd1058399d7 to 5db97e43a6c1449aff00899b2ea0ae6530c34fb7
Compare revisions
Changes are shown as if the
source
revision was being merged into the
target
revision.
Learn more about comparing revisions.
Source
bmcandre/assessment2
Select target project
No results found
5db97e43a6c1449aff00899b2ea0ae6530c34fb7
Select Git revision
Loading items
Swap
Target
bmcandre/assessment2
Select target project
bmcandre/assessment2
1 result
9e7607fa2e13259b15385726baf74bd1058399d7
Select Git revision
Loading items
Show changes
Only incoming changes from source
Include changes to target since source was created
Compare
Commits on Source
2
Update DotsAndBoxesGrid.java
· e4d6d082
Brett McAndrew
authored
Aug 2, 2023
e4d6d082
Merge branch '1-fix-assignment-errors' into 'main'
· 5db97e43
Brett McAndrew
authored
Aug 2, 2023
Errors fixed Closes
#1
See merge request
!2
5db97e43
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
+15
-6
15 additions, 6 deletions
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
with
15 additions
and
6 deletions
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
View file @
5db97e43
...
...
@@ -112,7 +112,9 @@ public class DotsAndBoxesGrid {
// A box is complete if the north and south horizontals and the east and west verticals have all been drawn.
// FIXME: You'll need to fix this code (after writing a test first).
return
true
;
return
(
getHorizontal
(
x
,
y
)
&&
getHorizontal
(
x
,
y
+
1
)
&&
getVertical
(
x
,
y
)
&&
getVertical
(
x
+
1
,
y
));
//return true;
}
/** Tries to claim a box for a player. If the box is complete, sets the ownership and returns true. */
...
...
@@ -139,9 +141,12 @@ public class DotsAndBoxesGrid {
throw
new
IndexOutOfBoundsException
(
String
.
format
(
"y was %d, which is out of range. Range is 0 to %d"
,
y
,
height
));
}
// FIXME: You need to throw an exception if the line was already drawn.
if
(
getHorizontal
(
x
,
y
))
{
throw
new
RuntimeException
(
"Horizontal was already drawn"
);
}
else
{
this
.
horizontals
[
x
][
y
]
=
true
;
}
// Try to claim the north or south boxes
boolean
claimN
=
claimBox
(
x
,
y
-
1
,
player
);
...
...
@@ -171,8 +176,12 @@ public class DotsAndBoxesGrid {
}
// You need to throw an exception if the line was already drawn.
if
(
getVertical
(
x
,
y
))
{
throw
new
RuntimeException
(
"Vertical was already drawn"
);
}
else
{
this
.
verticals
[
x
][
y
]
=
true
;
}
// Try to claim the north or south boxes
boolean
claimE
=
claimBox
(
x
,
y
,
player
);
boolean
claimW
=
claimBox
(
x
-
1
,
y
,
player
);
...
...
This diff is collapsed.
Click to expand it.