Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
A
Assessment2
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Brett McAndrew
Assessment2
Merge requests
!2
Errors fixed
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Errors fixed
1-fix-assignment-errors
into
main
Overview
0
Commits
1
Pipelines
0
Changes
1
Merged
Brett McAndrew
requested to merge
1-fix-assignment-errors
into
main
1 year ago
Overview
0
Commits
1
Pipelines
0
Changes
1
Expand
Closes
#1 (closed)
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
e4d6d082
1 commit,
1 year ago
1 file
+
15
−
6
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
+
15
−
6
Options
@@ -112,7 +112,9 @@ public class DotsAndBoxesGrid {
// A box is complete if the north and south horizontals and the east and west verticals have all been drawn.
// FIXME: You'll need to fix this code (after writing a test first).
return
true
;
return
(
getHorizontal
(
x
,
y
)
&&
getHorizontal
(
x
,
y
+
1
)
&&
getVertical
(
x
,
y
)
&&
getVertical
(
x
+
1
,
y
));
//return true;
}
/** Tries to claim a box for a player. If the box is complete, sets the ownership and returns true. */
@@ -139,9 +141,12 @@ public class DotsAndBoxesGrid {
throw
new
IndexOutOfBoundsException
(
String
.
format
(
"y was %d, which is out of range. Range is 0 to %d"
,
y
,
height
));
}
// FIXME: You need to throw an exception if the line was already drawn.
this
.
horizontals
[
x
][
y
]
=
true
;
if
(
getHorizontal
(
x
,
y
))
{
throw
new
RuntimeException
(
"Horizontal was already drawn"
);
}
else
{
this
.
horizontals
[
x
][
y
]
=
true
;
}
// Try to claim the north or south boxes
boolean
claimN
=
claimBox
(
x
,
y
-
1
,
player
);
@@ -171,8 +176,12 @@ public class DotsAndBoxesGrid {
}
// You need to throw an exception if the line was already drawn.
this
.
verticals
[
x
][
y
]
=
true
;
if
(
getVertical
(
x
,
y
))
{
throw
new
RuntimeException
(
"Vertical was already drawn"
);
}
else
{
this
.
verticals
[
x
][
y
]
=
true
;
}
// Try to claim the north or south boxes
boolean
claimE
=
claimBox
(
x
,
y
,
player
);
boolean
claimW
=
claimBox
(
x
-
1
,
y
,
player
);
Loading