Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
braines Assignment 2
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Brendan Raines
braines Assignment 2
Commits
2397619d
Commit
2397619d
authored
3 years ago
by
Brendan Raines
Browse files
Options
Downloads
Patches
Plain Diff
Issue 1 bugs fixed in code. Tests passed.
parent
b03e4d81
No related branches found
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
+9
-3
9 additions, 3 deletions
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
with
9 additions
and
3 deletions
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
+
9
−
3
View file @
2397619d
...
@@ -113,7 +113,7 @@ public class DotsAndBoxesGrid {
...
@@ -113,7 +113,7 @@ public class DotsAndBoxesGrid {
// A box is complete if the north and south horizontals and the east and west verticals have all been drawn.
// A box is complete if the north and south horizontals and the east and west verticals have all been drawn.
// FIXME: You'll need to fix this code (after writing a test first).
// FIXME: You'll need to fix this code (after writing a test first).
return
t
rue
;
return
t
his
.
horizontals
[
x
][
y
]
&&
this
.
horizontals
[
x
+
1
][
y
]
&&
this
.
verticals
[
x
][
y
]
&&
this
.
verticals
[
x
][
y
+
1
]
;
}
}
/** Tries to claim a box for a player. If the box is complete, sets the ownership and returns true. */
/** Tries to claim a box for a player. If the box is complete, sets the ownership and returns true. */
...
@@ -140,7 +140,10 @@ public class DotsAndBoxesGrid {
...
@@ -140,7 +140,10 @@ public class DotsAndBoxesGrid {
throw
new
IndexOutOfBoundsException
(
String
.
format
(
"y was %d, which is out of range. Range is 0 to %d"
,
y
,
height
));
throw
new
IndexOutOfBoundsException
(
String
.
format
(
"y was %d, which is out of range. Range is 0 to %d"
,
y
,
height
));
}
}
// FIXME: You need to throw an exception if the line was already drawn.
if
(
this
.
horizontals
[
x
][
y
])
{
throw
new
IllegalArgumentException
(
String
.
format
(
"Line already drawn at %d, %d"
,
x
,
y
));
}
this
.
horizontals
[
x
][
y
]
=
true
;
this
.
horizontals
[
x
][
y
]
=
true
;
...
@@ -172,7 +175,10 @@ public class DotsAndBoxesGrid {
...
@@ -172,7 +175,10 @@ public class DotsAndBoxesGrid {
}
}
// You need to throw an exception if the line was already drawn.
// You need to throw an exception if the line was already drawn.
if
(
this
.
verticals
[
x
][
y
])
{
throw
new
IllegalArgumentException
(
String
.
format
(
"Line already drawn at %d, %d"
,
x
,
y
));
}
this
.
verticals
[
x
][
y
]
=
true
;
this
.
verticals
[
x
][
y
]
=
true
;
// Try to claim the north or south boxes
// Try to claim the north or south boxes
boolean
claimE
=
claimBox
(
x
,
y
,
player
);
boolean
claimE
=
claimBox
(
x
,
y
,
player
);
...
...
This diff is collapsed.
Click to expand it.
Brendan Raines
@braines
mentioned in issue
#1 (closed)
·
3 years ago
mentioned in issue
#1 (closed)
mentioned in issue #1
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment