Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
A
Assessment 2
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Scott Crooks
Assessment 2
Merge requests
!1
Resolve "Fix errors in assignment"
Code
Review changes
Check out branch
Download
Patches
Plain diff
Expand sidebar
Merged
Resolve "Fix errors in assignment"
1-fix-errors-in-assignment
into
main
Overview
0
Commits
2
Pipelines
0
Changes
2
Merged
Scott Crooks
requested to merge
1-fix-errors-in-assignment
into
main
11 months ago
Overview
0
Commits
2
Pipelines
0
Changes
2
Closes
#1 (closed)
0
0
Merge request reports
Viewing commit
57597a4a
Prev
Next
Show latest version
2 files
+
11
−
5
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
57597a4a
Fixed bugs in boxComplete and drawVertical/Horizontal
· 57597a4a
Scott Crooks
authored
11 months ago
src/main/java/dotsandboxes/DotsAndBoxesGrid.java
+
10
−
4
View file @ 57597a4a
Edit in single-file editor
Open in Web IDE
Show full file
@@ -110,9 +110,13 @@ public class DotsAndBoxesGrid {
return
false
;
}
// A box is complete if the north and south horizontals and the east and west verticals have all been drawn.
// FIXME: You'll need to fix this code (after writing a test first).
return
true
;
// Could be shorter but this is more readable
boolean
north
=
horizontals
[
x
][
y
];
boolean
south
=
horizontals
[
x
][
y
+
1
];
boolean
west
=
verticals
[
x
][
y
];
boolean
east
=
verticals
[
x
+
1
][
y
];
return
north
&&
south
&&
west
&&
east
;
}
/** Tries to claim a box for a player. If the box is complete, sets the ownership and returns true. */
@@ -139,7 +143,8 @@ public class DotsAndBoxesGrid {
throw
new
IndexOutOfBoundsException
(
String
.
format
(
"y was %d, which is out of range. Range is 0 to %d"
,
y
,
height
));
}
// FIXME: You need to throw an exception if the line was already drawn.
// You need to throw an exception if the line was already drawn.
if
(
horizontals
[
x
][
y
])
throw
new
IllegalArgumentException
(
"Line is already taken."
);
this
.
horizontals
[
x
][
y
]
=
true
;
@@ -171,6 +176,7 @@ public class DotsAndBoxesGrid {
}
// You need to throw an exception if the line was already drawn.
if
(
verticals
[
x
][
y
])
throw
new
IllegalArgumentException
(
"Line is already taken."
);
this
.
verticals
[
x
][
y
]
=
true
;
// Try to claim the north or south boxes
Loading